Merge back teacher release#3639
Merged
tamaskozmer merged 3 commits intomasterfrom Apr 13, 2026
Merged
Conversation
refs: MBL-19940 affects: Student release note: Fixed an issue where students were logged out when entering split-screen or multi-window mode on Android tablets. (cherry picked from commit fc199e6)
Contributor
🧪 Unit Test Results📊 Summary
Last updated: Mon, 13 Apr 2026 07:49:41 GMT |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This is a small, focused patch release with two changes.
Positives:
- The
shouldIgnoreToken = trueremoval is the right fix. Thefeatures/environmentendpoint is called post-login to retrieve institution/user-specific feature flags, and the result is stored keyed byapiPrefs.user?.id— it clearly requires an authenticated request. The previous unauthenticated call was likely the root cause of incorrect or empty feature flag responses. - Version bump from 2.6.0 → 2.6.1 (versionCode 91 → 92) is consistent with a patch release.
Issues:
-
FeatureFlagProviderTest.kt:142— The'Save environment feature flags'test usesany()for RestParams, so it won't guard against the bug being re-introduced. The specificRestParams(particularlyshouldIgnoreToken = false) should be asserted — see inline comment.
Contributor
📊 Code Coverage Report✅ Student
✅ Teacher
✅ Pandautils
📈 Overall Average
|
kristofnemere
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.