Skip to content

Merge back parent release#3640

Merged
tamaskozmer merged 3 commits intomasterfrom
release/parent
Apr 13, 2026
Merged

Merge back parent release#3640
tamaskozmer merged 3 commits intomasterfrom
release/parent

Conversation

@tamaskozmer
Copy link
Copy Markdown
Contributor

No description provided.

tamaskozmer and others added 3 commits April 8, 2026 12:55
refs: MBL-19940
affects: Student
release note: Fixed an issue where students were logged out when entering split-screen or multi-window mode on Android tablets.

(cherry picked from commit fc199e6)
@github-actions
Copy link
Copy Markdown
Contributor

🧪 Unit Test Results


📊 Summary

  • Total Tests: 0
  • Failed: 0
  • Skipped: 0
  • Status: ⚠️ No test results found

Last updated: Mon, 13 Apr 2026 07:50:38 GMT

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

This is a small, focused patch release with two changes.

Version bump (apps/parent/build.gradle): Routine 4.11.04.11.1 patch bump.

FeatureFlagProvider.fetchEnvironmentFeatureFlags: Removes shouldIgnoreToken = true from the RestParams. This is the right fix — the flag was causing the GET /api/v1/features/environment request to be sent without an Authorization header, even though the function is always invoked post-authentication (in SplashViewModel, CallbackActivity, and InitActivity) and stores results keyed by the logged-in user's ID. The corrected behavior is also consistent with how FeaturesManager.getEnvironmentFeatureFlags has always called the same endpoint.

Issues

  • Test doesn't verify the exact RestParamslibs/pandautils/src/test/java/com/instructure/pandautils/utils/FeatureFlagProviderTest.kt:142: The any() matcher means the test won't catch future changes to RestParams (e.g., accidentally re-adding shouldIgnoreToken = true or dropping isForceReadFromNetwork = true). See inline comment for a suggested tighter assertion.

@github-actions
Copy link
Copy Markdown
Contributor

📊 Code Coverage Report

✅ Student

  • PR Coverage: 42.65%
  • Master Coverage: 42.65%
  • Delta: +0.00%

✅ Teacher

  • PR Coverage: 25.37%
  • Master Coverage: 25.37%
  • Delta: +0.00%

✅ Pandautils

  • PR Coverage: 23.69%
  • Master Coverage: 23.69%
  • Delta: +0.00%

📈 Overall Average

  • PR Coverage: 30.57%
  • Master Coverage: 30.57%
  • Delta: +0.00%

@tamaskozmer tamaskozmer merged commit e6dd176 into master Apr 13, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants