Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-drawer-layout): drawer tray should trap focus in overlay mode if shouldContainFocus prop is set to true #1902

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ui-drawer-layout): drawer tray should trap focus in overlay mode if shouldContainFocus prop is set to true #1902

wants to merge 1 commit into from

Conversation

balzss
Copy link
Contributor

@balzss balzss commented Mar 11, 2025

INSTUI-4401

test plan:

  • go to the drawer layout example and check if by default it traps the focus in overlay mode (set the window size to small)
  • by default it shouldn't trap the focus in desktop mode
  • if you set explicitly the shouldContainFocus prop in the DrawerLayout.Tray, it should follow that setting (but still respect viewport size)

@balzss balzss requested review from matyasf and joyenjoyer March 11, 2025 17:11
@balzss balzss self-assigned this Mar 11, 2025
@github-actions GitHub Actions
Copy link

PR Preview Action v1.6.0

🚀 View preview at
https://instructure.design/pr-preview/pr-1902/

Built to branch gh-pages at 2025-03-11 17:16 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyenjoyer joyenjoyer joyenjoyer approved these changes

@matyasf matyasf Awaiting requested review from matyasf

At least 2 approving reviews are required to merge this pull request.

Assignees

@balzss balzss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balzss @joyenjoyer