Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-side-nav-bar): make screenreaders announce Badge text in SideN… #1909

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ui-side-nav-bar): make screenreaders announce Badge text in SideN… #1909

wants to merge 1 commit into from

Conversation

ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Mar 18, 2025 •
edited
Loading

…avBar

INSTUI-4292

ISSUE:

  • in Safari with VoiceOver, and with NVDA and JAWS, the Badge count in SideNavBar example was not announced, it worked only in Chrome with VoiceOver

TEST PLAN:

  • go over the SideNavBar example with Voiceover in Safari and Chrome, it should announce the text "You have 99 unread messages."
  • go over the SideNavBar example with NVDA and JAWS, they should announce the text "You have 99 unread messages."

@ToMESSKa ToMESSKa self-assigned this Mar 18, 2025
@github-actions GitHub Actions
Copy link

PR Preview Action v1.6.0

🚀 View preview at
https://instructure.design/pr-preview/pr-1909/

Built to branch gh-pages at 2025-03-18 08:55 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ToMESSKa ToMESSKa requested review from matyasf and joyenjoyer March 18, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyasf matyasf Awaiting requested review from matyasf

@joyenjoyer joyenjoyer Awaiting requested review from joyenjoyer

At least 2 approving reviews are required to merge this pull request.

Assignees

@ToMESSKa ToMESSKa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ToMESSKa