fix(github_repository_file): delete error handling and codesigning

[ivanmartos]

Resolves #2735

---

Before the change?

• currently deleting github_repository_file fails silently
• when deletinggithub_repository_file then incomplete RepositoryContentFileOptions is passed to github sdk. This means that deletion commit is not signed and in case there is a ruleset requiring signed commits, this delete commit will fail silently
• currently when all tests are executed for TestAccGithubRepositoryFile they fail with duplicate repository name

After the change?

• deletion of github_repository_file no longer fails silently, but if there is an error, it is retruned
• proper RepositoryContentFileOptions is passed to sdk call to DeleteFile (same as for create and update methods). This way commits are signed
• each TestAccGithubRepositoryFile test execution creates new repository specific for given test

Pull request checklist

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• Yes
• No

---

[nickfloyd]

This is technically a breaking change - prior to the change this would fail forward, after the change an error is thrown - functionally the operation does not work either way but user workflows could be disrupted even still.

We'll schedule this one to go out in the up coming major release. Thank you for working on this change - we'll work to get it out the door!

[nickfloyd]

I'm rolling my previous comment back. We implemented some fixes to more appropriately handle things like this for archived repos - the behavior defined in that change set and this one is, I feel, what is expected.

fixed concerns