Skip to content

Comments

[MAINT] Consolidate ID format of github_emu_group_mapping#3215

Open
deiga wants to merge 4 commits intointegrations:mainfrom
F-Secure-web:consolidate-emu-group-mapping-id
Open

[MAINT] Consolidate ID format of github_emu_group_mapping#3215
deiga wants to merge 4 commits intointegrations:mainfrom
F-Secure-web:consolidate-emu-group-mapping-id

Conversation

@deiga
Copy link
Collaborator

@deiga deiga commented Feb 21, 2026

Resolves #3200


Before the change?

  • Import ID and Resource ID had different format
  • tflog.SetField was being used incorrectly
  • Tests didn't use terraform-plugin-testing
  • Some tests didn't fully work
  • Docs were missing computed fields

After the change?

  • Import ID and Resource ID have the same format
  • Fixes tflog.SetField usage
  • Updates tests to use terraform-plugin-testing
  • Fixed tests
  • Updates docs

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@github-actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@deiga deiga added this to the v6.12.0 Release milestone Feb 21, 2026
@deiga deiga requested a review from stevehipwell February 21, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MAINT] Consolidate ID in EMU group mapping resource

1 participant