rm duplicate args of the quantization extra config #1334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: WeiweiZhang1 <weiwei1.zhang@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes duplicate arguments from quantization extra configuration by only saving attributes that differ from the default Scheme values, reducing redundancy in the saved configuration files.
Changes:
- Modified export functions to filter extra_config entries, keeping only attributes that differ from scheme defaults
- Updated test cases to verify that duplicate/default values are not present in extra_config
- Added assertions to ensure extra_config contains only non-default attributes
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| auto_round/export/export_to_autoround/export_to_nvfp_mxfp.py | Updated logic to save only non-equal keys in extra_config for both layer configs and regex configs |
| auto_round/export/export_to_autoround/export_to_fp8.py | Changed iteration from scheme_keys to neq_keys to avoid saving default values |
| auto_round/export/export_to_autoround/export.py | Added filtering logic for regex_config to save only attributes differing from scheme defaults |
| test/test_cuda/quantization/test_mix_bits.py | Added assertions to verify extra_config excludes default values and removed redundant config entries from test data |
| test/test_cpu/quantization/test_mix_bits.py | Added assertions to verify extra_config excludes default values and removed redundant config entries from test data |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please briefly describe your main changes, the motivation.
Type of Change
Related Issues
Fixes or relates to #1187
Checklist Before Submitting