Fix associate() handling of #include from symlink #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing TreeAssociator with a function introduced a bug in the corner case when an #include directive is encountered inside of a symlink. Signed-off-by: John Pennycook <[email protected]>
The information stored within a ParserState is tied to a file's real path, not its absolute path. We need to call realpath() before passing a filename to evaluate_for_platform() to ensure that it can be used for indexing. Signed-off-by: John Pennycook <[email protected]>
Pennycook
force-pushed
the
associate-fix
branch
from
a23bf25 to
7032e46
Compare
laserkelvin
approved these changes
Dec 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Fixes a bug inadvertently introduced by #125, which I found in offline stress-testing.
Proposed changes
associate()by ensuring we callrealpathbefore passing filenames toevaluate_for_platform.