Skip to content

Switch to finalized coverage schema #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2025

Conversation

Pennycook
Copy link
Contributor

Related issues

Proposed changes

  • Copy across the schema from the P3 Analysis Library.
  • Generate used_lines and unused_lines when invoking cbi-cov.
  • Update the cbi-cov tests.

@laserkelvin, I've opened this as a draft because I want to make sure that you're happy with intel/p3-analysis-library#75, and I don't want this to accidentally get merged first. I've opened it early primarily so you have the option to run something that can generate the new coverage format.

This splits "lines" into "used_lines" and "unused_lines", which is necessary to
compute coverage.

Signed-off-by: John Pennycook <[email protected]>
@Pennycook Pennycook added the enhancement New feature or request label Mar 21, 2025
@Pennycook Pennycook added this to the 2.0.0 milestone Mar 21, 2025
@Pennycook Pennycook requested a review from laserkelvin March 21, 2025 13:31
Copy link
Contributor

@laserkelvin laserkelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after reviewing the corresponding P3 library PR

@Pennycook Pennycook marked this pull request as ready for review April 3, 2025 15:16
@Pennycook Pennycook merged commit 5c81ed5 into intel:main Apr 3, 2025
4 checks passed
@Pennycook Pennycook deleted the feature/coverage-format branch April 3, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend coverage format to support computing coverage
2 participants