Suppress the perf script crash with logging if it happens#994
Closed
mlim19 wants to merge 2 commits into
Closed
Conversation
| [perf_path(), "script", "-F", "+pid", "-i", str(perf_data)], | ||
| suppress_log=True, | ||
| ) | ||
| perf_script_cmd = [perf_path(), "script", "-F", "+pid", "-i", str(perf_data)] |
Contributor
There was a problem hiding this comment.
thanks @mlim19 for the error handling fix,
To make sure we see samples in the ui when perf fails, we also need this fix : pinterest@3b33e31
I can get it committed.
But curious if we can solve the root cause of version compatibility to support perf on g family.
Contributor
Author
There was a problem hiding this comment.
@prashantbytesyntax, your fix looks good to me. You can combine it in this PR or submit it separately.
mlim19
force-pushed
the
handle_perf_script_crash
branch
from
937cd12 to
490f182
Compare
Signed-off-by: Min Lim <min.yeol.lim@intel.com>
dkorlovs
force-pushed
the
handle_perf_script_crash
branch
from
490f182 to
0b0723f
Compare
3 tasks
Contributor
Author
|
Discard this PR because it's merged as a part of other PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this patch fixes #992.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots
Checklist: