-
Notifications
You must be signed in to change notification settings - Fork 81
Implement BlockPointerToTensorDesc pass
#5766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
294ff2d to
90407e8
Compare
Signed-off-by: Whitney Tsang <[email protected]>
90407e8 to
3a97c0f
Compare
|
Please link the issue to the PR. |
done |
etiotto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial comments.
third_party/intel/lib/Dialect/Triton/Transforms/BlockPointerToTensorDesc.cpp
Show resolved
Hide resolved
third_party/intel/lib/Dialect/Triton/Transforms/BlockPointerToTensorDesc.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/Dialect/Triton/Transforms/BlockPointerToTensorDesc.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/Dialect/Triton/Transforms/BlockPointerToTensorDesc.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/Dialect/Triton/Transforms/BlockPointerToTensorDesc.cpp
Show resolved
Hide resolved
third_party/intel/lib/Dialect/Triton/Transforms/BlockPointerToTensorDesc.cpp
Show resolved
Hide resolved
third_party/intel/lib/Dialect/Triton/Transforms/BlockPointerToTensorDesc.cpp
Show resolved
Hide resolved
b964b2c to
e0da90e
Compare
Signed-off-by: Whitney Tsang <[email protected]>
e0da90e to
ba9de05
Compare
Signed-off-by: Whitney Tsang <[email protected]>
094a308 to
6b28dc6
Compare
|
To check: |
Signed-off-by: Whitney Tsang <[email protected]>
third_party/intel/lib/Dialect/Triton/Transforms/BlockPointerToTensorDesc.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/Dialect/Triton/Transforms/BlockPointerToTensorDesc.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/Dialect/Triton/Transforms/BlockPointerToTensorDesc.cpp
Show resolved
Hide resolved
third_party/intel/lib/Dialect/Triton/Transforms/BlockPointerToTensorDesc.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/Dialect/Triton/Transforms/BlockPointerToTensorDesc.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Whitney Tsang <[email protected]>
…ointerToTensorDesc
This PR implements the
BlockPointerToTensorDescpass, which translates block pointer representations to tensor descriptor pointer representations. As part of the planned deprecation of block pointer representations, this pass serves as a transitional solution. Since many existing kernels still use block pointers, we cannot immediately remove block pointer support from the compiler. To simplify the compiler architecture and avoid maintaining dual pointer representation handling, this pass converts block pointers to tensor descriptors, allowing us to standardize on a single pointer representation throughout the compilation pipeline.Note: Currently, the pipeline immediately translates tensor descriptors back to block pointers. However, we plan to incrementally update each compilation step to handle tensor descriptors directly, eventually eliminating the need for block pointer representations entirely.
Fixes #5784.
No geomean performance regressions:
Triton Benchmarks PVC: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/20633795972
Triton Benchmarks BMG: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/20633799845 + https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/20642028915