Skip to content

Conversation

@whitneywhtsang
Copy link
Contributor

min_dot_size was moved inside XPUBackend in #5329, which makes user experience inconsistent with other backends.

@whitneywhtsang
Copy link
Contributor Author

What do reviewers think of moving min_dot_size back out?

@chengjunlu
Copy link
Contributor

What do reviewers think of moving min_dot_size back out?

It has to be removed back out for supporting the Helion.

@whitneywhtsang whitneywhtsang marked this pull request as ready for review January 7, 2026 01:27
@anmyachev
Copy link
Contributor

What do reviewers think of moving min_dot_size back out?

It's fine if we don't break anything. @AndreyPavlenko please take a look.

@AndreyPavlenko
Copy link
Contributor

AndreyPavlenko commented Jan 7, 2026

It has been moved because it's backend specific. Different backends may have different implementations.
What's the issue of using it as a class method? Here is an example - #5329 (comment)

@whitneywhtsang
Copy link
Contributor Author

It has been moved because it's backend specific. Different backends may have different implementations. What's the issue of using it as a class method?

Different from CUDA, which make users like Helion to have xpu specific changes.

@AndreyPavlenko
Copy link
Contributor

What about something like this?

def min_dot_size(device_props: dict):
    backend = XPUBackend(triton.runtime.driver.active.get_current_target())
    return backend.min_dot_size(device_props)

@whitneywhtsang
Copy link
Contributor Author

What about something like this?

def min_dot_size(device_props: dict):
    backend = XPUBackend(triton.runtime.driver.active.get_current_target())
    return backend.min_dot_size(device_props)

It should work, changed.

@whitneywhtsang whitneywhtsang changed the title Move min_dot_size out of XPUBackend Define min_dot_size outside of XPUBackend Jan 7, 2026
Signed-off-by: Whitney Tsang <[email protected]>
@whitneywhtsang whitneywhtsang force-pushed the whitneywhtsang/min_dot_size branch from 3a33d5b to 6067d4e Compare January 7, 2026 17:31
Signed-off-by: Whitney Tsang <[email protected]>
Signed-off-by: Whitney Tsang <[email protected]>
@anmyachev anmyachev merged commit c72d0f4 into main Jan 8, 2026
50 of 52 checks passed
@anmyachev anmyachev deleted the whitneywhtsang/min_dot_size branch January 8, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants