-
Notifications
You must be signed in to change notification settings - Fork 81
Define min_dot_size outside of XPUBackend
#5777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Whitney Tsang <[email protected]>
|
What do reviewers think of moving |
It has to be removed back out for supporting the Helion. |
It's fine if we don't break anything. @AndreyPavlenko please take a look. |
|
It has been moved because it's backend specific. Different backends may have different implementations. |
Different from CUDA, which make users like Helion to have xpu specific changes. |
|
What about something like this? def min_dot_size(device_props: dict):
backend = XPUBackend(triton.runtime.driver.active.get_current_target())
return backend.min_dot_size(device_props) |
It should work, changed. |
min_dot_size out of XPUBackendmin_dot_size outside of XPUBackend
Signed-off-by: Whitney Tsang <[email protected]>
3a33d5b to
6067d4e
Compare
Signed-off-by: Whitney Tsang <[email protected]>
Signed-off-by: Whitney Tsang <[email protected]>
min_dot_sizewas moved insideXPUBackendin #5329, which makes user experience inconsistent with other backends.