[CI] Build on Windows: use GitHub-hosted windows-2022 CPU runner (#7443)#7555
Open
slawblauciak wants to merge 1 commit into
Open
[CI] Build on Windows: use GitHub-hosted windows-2022 CPU runner (#7443)#7555slawblauciak wants to merge 1 commit into
slawblauciak wants to merge 1 commit into
Conversation
The Build on Windows workflow only compiles Triton and does not use a GPU, so run it on the GitHub-hosted, CPU-only windows-2022 runner instead of the self-hosted GPU pool. Set up MSVC via ilammy/msvc-dev-cmd (matching llvm-build.yml) rather than a hardcoded vcvarsall.bat path, and drop the reliance on a runner-preinstalled ninja (ninja<1.13.0 is pinned in pyproject.toml). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Well are we OK with GH-hosted runners? I suppose they are expensive and we have our own infrastructure. By tomorrow evening I will update this thread with a Windows runner including all our build tools, so no need to implement toolchain provisioning on each run. |
Contributor
|
In this PR, please just separate the build step, running on our existing GPU runners. |
Contributor
|
I need a little more time and plan to launch the runner tomorrow. I can handle also workflow changes to separate the build step. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7443