[AxisInfo] Fix signed division/remainder analysis and revert PyTorch floordiv workaround#7570
Draft
whitneywhtsang wants to merge 1 commit into
Draft
[AxisInfo] Fix signed division/remainder analysis and revert PyTorch floordiv workaround#7570whitneywhtsang wants to merge 1 commit into
whitneywhtsang wants to merge 1 commit into
Conversation
…floordiv workaround The previous fix (#6896) used a `divisibility >= contiguity` guard for DivSIOp/RemSIOp which is insufficient — truncation toward zero breaks constancy even within purely negative windows (counterexample: sdiv([-64..-57], 32) = [-2,-1,-1,-1,-1,-1,-1,-1], not constant-8). Completely disable the constancy/contiguity/divisibility optimizations for DivSIOp and RemSIOp in AxisInfo. Without range analysis we cannot prove inputs are non-negative, so we conservatively return 1 for all three properties. Add a PyTorch patch to bypass the XOR-based floordiv workaround (pytorch/pytorch#175168) for XPU, using the simple tl.where-based floordiv instead. Fixes #6376 Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix (#6896) used a
divisibility >= contiguityguard for DivSIOp/RemSIOp which is insufficient — truncation toward zero breaks constancy even within purely negative windows (counterexample: sdiv([-64..-57], 32) = [-2,-1,-1,-1,-1,-1,-1,-1], not constant-8).Completely disable the constancy/contiguity/divisibility optimizations for DivSIOp and RemSIOp in AxisInfo. Without range analysis we cannot prove inputs are non-negative, so we conservatively return 1 for all three properties.
Add a PyTorch patch to bypass the XOR-based floordiv workaround (pytorch/pytorch#175168) for XPU, using the simple tl.where-based floordiv instead.
Fixes #6376