Changed nmake to build against MSVCRT (/MD, /MDd) #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When the runtime type option is omitted, VC++ builds object files with a `LIBCMT` directive, which is a thread-safe statically linked runtime library. * This change adds explicit release and debug dynamic CRT options into build configurations. Signed-off-by: gh-andre <[email protected]>
|
Just a quick note here - it probably makes sense to mention this change in release notes, as it may affect those who customized their projects to either patch the source to use the dynamic CRT, like I did for mine, or to structure their projects around a static CRT, which means that they will not share memory allocation, global initialization, like threading/locking, etc., with those same resources in |
|
PR merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LIBCMTdirective, which is a thread-safe statically linked runtime library.