Replace GetElementCoord to cooperative matrix version#20855
Draft
Replace GetElementCoord to cooperative matrix version#20855
Conversation
vmaksimo
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
vmaksimo
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
vmaksimo
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vmaksimo
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vmaksimo
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
vmaksimo
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
MrSidims
approved these changes
Dec 9, 2025
Contributor
vinser52
approved these changes
Jan 14, 2026
Contributor
Author
|
This one should be merged together/as a part of the next pulldown from Khronos which will include merged KhronosGroup/SPIRV-LLVM-Translator#3468 |
vmaksimo
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
vmaksimo
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vmaksimo
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
iclsrc
approved these changes
Apr 8, 2026
Collaborator
iclsrc
left a comment
iclsrc
left a comment
There was a problem hiding this comment.
Clean rename completing the pre-existing TODO. The SPIRV backend (SPIRVBuiltins.td) already maps __spirv_CooperativeMatrixGetElementCoordINTEL to OpCooperativeMatrixGetElementCoordINTEL (opcode 6440), so the declaration and call-site updates in these headers are correct and sufficient. E2e coverage exists in sycl/test-e2e/Matrix/get_coordinate_ops.cpp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.