Draft
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+38
to
+43
| run: | | ||
| echo "SCCACHE_DIR=$env:CCACHE_DIR_INPUT" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append | ||
| echo "SCCACHE_MAXSIZE=10G" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append | ||
| # Wthout this we get a linking error about not being able to find sycl-devicelib-host.lib | ||
| echo "LIB=$env:LIB;$env:SYCL_DIR_INPUT\lib" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append | ||
| echo "CMAKE_EXTRA_ARGS=-DWITH_WINDOWS_SCCACHE=ON" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append |
Contributor
Author
There was a problem hiding this comment.
@KornevNikita Do we need these checks to pass before merging PRs or are we allowed to ignore them?
This warning seems to suggest we aren't allowed to modify any environment variables with non-static strings, and we have to set these vars to get things to work. We already do that heavily in other workflows, it's just the checks were added after those workflows were written. Thanks
Contributor
There was a problem hiding this comment.
Yeah, this is annoying, I suggest we ignore these :)
Contributor
Author
There was a problem hiding this comment.
I like that answer, thanks :P
Comment on lines
+38
to
+43
| run: | | ||
| echo "SCCACHE_DIR=$env:CCACHE_DIR_INPUT" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append | ||
| echo "SCCACHE_MAXSIZE=10G" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append | ||
| # Wthout this we get a linking error about not being able to find sycl-devicelib-host.lib | ||
| echo "LIB=$env:LIB;$env:SYCL_DIR_INPUT\lib" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append | ||
| echo "CMAKE_EXTRA_ARGS=-DWITH_WINDOWS_SCCACHE=ON" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append |
Comment on lines
+38
to
+43
| run: | | ||
| echo "SCCACHE_DIR=$env:CCACHE_DIR_INPUT" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append | ||
| echo "SCCACHE_MAXSIZE=10G" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append | ||
| # Wthout this we get a linking error about not being able to find sycl-devicelib-host.lib | ||
| echo "LIB=$env:LIB;$env:SYCL_DIR_INPUT\lib" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append | ||
| echo "CMAKE_EXTRA_ARGS=-DWITH_WINDOWS_SCCACHE=ON" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append |
Comment on lines
+38
to
+43
| run: | | ||
| echo "SCCACHE_DIR=$env:CCACHE_DIR_INPUT" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append | ||
| echo "SCCACHE_MAXSIZE=10G" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append | ||
| # Wthout this we get a linking error about not being able to find sycl-devicelib-host.lib | ||
| echo "LIB=$env:LIB;$env:SYCL_DIR_INPUT\lib" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append | ||
| echo "CMAKE_EXTRA_ARGS=-DWITH_WINDOWS_SCCACHE=ON" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append |
sarnex
force-pushed
the
sarnex/blender
branch
2 times, most recently
from
04d162e to
d8e53e1
Compare
Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a real world test into CI.
The idea is we build and run Blender using the just-built SYCL compiler (initially, only the nightly) and then run an exmample workflow on a (multi) GPU system.
The first version of this PR only tracks pass/fail, but in the future we could add a performance threshold to cause a fail.
First we build OIDN and Embree, both of which use SYCL and DPC++. Then we build Blender with the just-built OIDN, Embree and SYCL compiler.
The steps of this workflow (as in, what to do at a high level) was developed with help from internal Blender experts.
Run in nightly example: https://github.com/intel/llvm/actions/runs/24317863959
Entire workflow takes ~10 minutes.