Skip to content

[SYCL] Follow up fix after #21706 #21800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarnex merged 2 commits into from
Apr 17, 2026
Merged

[SYCL] Follow up fix after #21706 #21800

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ed18fa
[SYCL] Follow up fix after #21706
againull Apr 17, 2026
346b3d3
Address review
againull Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sycl/include/sycl/detail/defines.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,12 @@
#pragma message( \
"No assumptions will be emitted due to no __builtin_assume available")
#else
#if defined(__cplusplus) && __cplusplus >= 202302L
#warning "No assumptions will be emitted due to no __builtin_assume available"
Copy link
Copy Markdown
Contributor

@sarnex sarnex Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead could we use #pragma message in all cases? i think it works on msvc/gcc/clang

Copy link
Copy Markdown
Contributor Author

@againull againull Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thx!

#endif
#endif
#endif
#endif

// FIXME Check for __SYCL_DEVICE_ONLY__ can be removed if implementation of
// __has_attribute is fixed to consider LangOpts when generating attributes in
Expand Down
Loading