[UR] Fix isPVC() to handle unsupported UR_DEVICE_INFO_DEVICE_ID#22006
Open
ldorau wants to merge 1 commit into
Open
[UR] Fix isPVC() to handle unsupported UR_DEVICE_INFO_DEVICE_ID#22006ldorau wants to merge 1 commit into
ldorau wants to merge 1 commit into
Conversation
The isPVC() utility used EXPECT_EQ which recorded a test failure when the adapter does not support UR_DEVICE_INFO_DEVICE_ID (e.g. Native CPU). This caused the test to be marked FAILED even though it would subsequently skip via GTEST_SKIP(). Return false instead of asserting when the query fails — if the adapter cannot report a device ID, the device is clearly not a PVC. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
pbalcer
approved these changes
May 13, 2026
Contributor
|
@intel/llvm-gatekeepers please consider merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The isPVC() utility used EXPECT_EQ which recorded a test failure when
the adapter does not support UR_DEVICE_INFO_DEVICE_ID (e.g. Native
CPU). This caused the test to be marked FAILED even though it would
subsequently skip via GTEST_SKIP().
Return false instead of asserting when the query fails — if the adapter
cannot report a device ID, the device is clearly not a PVC.