[SYCL][E2E] Accept default walk-order attribute in kernel_info_attr test#22279
Open
crystarm wants to merge 2 commits into
Open
[SYCL][E2E] Accept default walk-order attribute in kernel_info_attr test#22279crystarm wants to merge 2 commits into
crystarm wants to merge 2 commits into
Conversation
Comment on lines
4
to
5
Contributor
There was a problem hiding this comment.
If this fix is intended to fix the test, you may also want to remove the UNSUPPORTED line, so we can test the fix in CI.
crystarm
force-pushed
the
fix/sycl-kernel-info-attr
branch
from
2a209f8 to
6cd9bc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #22226.
What changed
Updated
sycl/test-e2e/Basic/kernel_info_attr.cpp:info::kernel::attributesto be emptyintel_reqd_workgroup_walk_order(0,1,2)The test still verifies consistency between:
kernel::get_info<info::kernel::attributes>()ext::oneapi::get_kernel_info<..., info::kernel::attributes>()Why
On Level Zero, runtime/driver may expose default walk-order metadata as a kernel attribute.
This is valid behavior and should not fail the test.
Validation
UR_LOADER_USE_LEVEL_ZERO_V2=0) passes.UR_RESULT_ERROR_UNSUPPORTED_FEATUREbefore reaching the assertion.