Skip to content

[SYCL][E2E] Fix LIT feature name #23088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uditagarwal97 wants to merge 1 commit into
base: sycl
Choose a base branch
from
+1 −1
Open

[SYCL][E2E] Fix LIT feature name #23088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/test-e2e/Adapters/level_zero/sycl-ls-gpu-default.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// REQUIRES: gpu, level-zero

@bader bader Sep 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing -/_ from the lit feature name to avoid similar bugs in the future. It won't prevent other typos, but this specific one is just ridiculous.

@uditagarwal97 uditagarwal97 Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a lot of LIT features with - or _ in their name, renaming all of them would be a big change. How about we instead make LIT throw an error if it encounters an unknown LIT feature?
IIRC we already maintain a list of approved LIT features to decide if it's build-time or runtime feature.

@KornevNikita KornevNikita Sep 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a lot of LIT features with - or _ in their name, renaming all of them would be a big change. How about we instead make LIT throw an error if it encounters an unknown LIT feature? IIRC we already maintain a list of approved LIT features to decide if it's build-time or runtime feature.

That's a good idea, I believe we have more typos. I tried to implement it previously, but it got bogged down in discussion.

@uditagarwal97 uditagarwal97 Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KornevNikita I like the solution you proposed in #16019 - it's easy to maintain, extend, and require minimal changes. Let me try it out

// REQUIRES: gpu, level_zero

// TODO: Remove unsetting SYCL_DEVICE_FILTER when feature is dropped
// RUN: %{run-unfiltered-devices} env --unset=SYCL_DEVICE_FILTER --unset=ONEAPI_DEVICE_SELECTOR sycl-ls --verbose | \
Expand Down
Loading