Skip to content

[SYCL] Make device_event::wait() noexcept #23103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KornevNikita wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[SYCL] Make device_event::wait() noexcept #23103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/include/sycl/device_event.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class device_event {

device_event(__ocl_event_t Event) : m_Event(Event) {}

void wait() {
void wait() noexcept {
(void)m_Event;
#ifdef __SYCL_DEVICE_ONLY__
__spirv_GroupWaitEvents(__spv::Scope::Workgroup, 1, &m_Event);
Expand Down
1 change: 1 addition & 0 deletions sycl/test/basic_tests/nd_item_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,5 +132,6 @@ static_assert(noexcept(std::declval<const Item &>().async_work_group_copy(
std::declval<DecoratedGlobalIntPtr>(),
std::declval<DecoratedLocalConstIntPtr>(), std::size_t{})));

static_assert(noexcept(std::declval<sycl::device_event &>().wait()));
static_assert(noexcept(
std::declval<const Item &>().wait_for(std::declval<sycl::device_event>())));
Loading