[SYCL][E2E] guard on tests, note about VS 2019 - #23106
Open
cperkinsintel wants to merge 1 commit into
Open
Conversation
uditagarwal97
approved these changes
Sep 4, 2026
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Updates SYCL E2E std::complex exp edge-case tests to run with explicit non-fast-math flags (matching SYCLOS defaults) and documents a known Windows/MSVC 2019 STL header issue.
Changes:
- Add a
mathflagslit substitution to force-fno-fast-math(or/clang:-fno-fast-mathundercl_options). - Update build
RUNlines to compile with the newmathflags. - Add a note about failures with MSVC 2019 STL headers on Windows.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| sycl/test-e2e/DeviceLib/exp/exp-std-complex-float-edge-cases.cpp | Adds mathflags substitution, uses it in build RUN, and documents MSVC 2019 STL header issue. |
| sycl/test-e2e/DeviceLib/exp/exp-std-complex-double-edge-cases.cpp | Same as float variant, plus preserves fp64 requirement. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+8
to
+10
| // DEFINE: %{mathflags} = %if cl_options %{/clang:-fno-fast-math%} %else %{-fno-fast-math%} | ||
| // | ||
| // RUN: %{build} -o %t.out | ||
| // RUN: %{build} %{mathflags} -o %t.out |
| // UNSUPPORTED-INTENDED: This test is intended for backends with SPIR-V support. | ||
| // | ||
| // RUN: %{build} -o %t.out | ||
| // DEFINE: %{mathflags} = %if cl_options %{/clang:-fno-fast-math%} %else %{-fno-fast-math%} |
Comment on lines
+13
to
+14
| // NOTE: on Windows this test will fail with MSVC 2019 STL headers | ||
| // due to a bug in those headers. |
Comment on lines
+12
to
+13
| // NOTE: on Windows this test will fail with MSVC 2019 STL headers | ||
| // due to a bug in those headers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests in question are passing just fine in SYCLOS which defaults to {{-fno-fast-math}}, but would fail if fast math were used.
Like the other tests in this oeuvre it should really specify the flag if that is a limitation. Note, also, that this trips over a known (and since fixed) bug in the Windows MSVC STL headers from VS 2019. We don't have gating for MSVC versions in our test harness, so I'm simply noting this.