[UR][L0] Treat ZE_RESULT_ERROR_NOT_AVAILABLE as unsupported fan speed query - #23113
Draft
ldorau wants to merge 1 commit into
Draft
Conversation
… query CI on Level Zero V2 / Arc B580 started failing urDeviceGetInfoTest.SuccessFanSpeed: zesFanGetState(ZES_FAN_SPEED_UNITS_PERCENT) now returns ZE_RESULT_ERROR_NOT_AVAILABLE instead of ZE_RESULT_ERROR_UNSUPPORTED_FEATURE on this hardware/KMD combination. ze2urResult() maps NOT_AVAILABLE to UR_RESULT_ERROR_INVALID_OPERATION, which the conformance test doesn't accept as an optional-query failure (it only allows UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION), so UR_DEVICE_INFO_FAN_SPEED failed with an unrelated error instead of being reported as unsupported. Check the raw ze_result_t before conversion and treat both ZE_RESULT_ERROR_UNSUPPORTED_FEATURE and ZE_RESULT_ERROR_NOT_AVAILABLE as 'this fan cannot report its state', consistently returning UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION for either. Ref: https://github.com/intel/llvm/actions/runs/34096141372/job/101664166940?pr=23110 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on Level Zero V2 / Arc B580 started failing
urDeviceGetInfoTest.SuccessFanSpeed: zesFanGetState(ZES_FAN_SPEED_UNITS_PERCENT)
now returns ZE_RESULT_ERROR_NOT_AVAILABLE instead of
ZE_RESULT_ERROR_UNSUPPORTED_FEATURE on this hardware/KMD combination.
ze2urResult() maps NOT_AVAILABLE to UR_RESULT_ERROR_INVALID_OPERATION, which
the conformance test doesn't accept as an optional-query failure (it only
allows UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION), so
UR_DEVICE_INFO_FAN_SPEED failed with an unrelated error instead of being
reported as unsupported.
Check the raw ze_result_t before conversion and treat both
ZE_RESULT_ERROR_UNSUPPORTED_FEATURE and ZE_RESULT_ERROR_NOT_AVAILABLE as
'this fan cannot report its state', consistently returning
UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION for either.
Ref: https://github.com/intel/llvm/actions/runs/34096141372/job/101664166940?pr=23110