[UR][L0v2] Remove unused ZeCopyOffloadExtensionSupported flag - #23114
Open
ldorau wants to merge 1 commit into
Open
[UR][L0v2] Remove unused ZeCopyOffloadExtensionSupported flag#23114ldorau wants to merge 1 commit into
ldorau wants to merge 1 commit into
Conversation
After the fix in intel#23110 (which changed createCommandList()'s copy-offload-support check to rely solely on ZeCopyOffloadQueueFlagSupported / ZeCopyOffloadListFlagSupported), ZeCopyOffloadExtensionSupported is set during platform initialization but never read anywhere in any conditional logic. It only flowed through: platform.cpp (probed from the driver's extension list) -> context.cpp (passed to command_list_cache_t's constructor) -> command_list_cache.hpp/cpp (stored as a class member), without affecting behavior. Remove the flag and its now-pointless extension name/version probing block across platform.hpp/.cpp, context.cpp, and command_list_cache.hpp/.cpp. No behavior change; the ur_zex_intel_queue_copy_operations_offload_hint_exp_desc_t descriptor and its pNext fallback usage are unrelated and unaffected. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
ldorau
marked this pull request as ready for review
September 7, 2026 13:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the fix in #23110 (which changed createCommandList()'s
copy-offload-support check to rely solely on
ZeCopyOffloadQueueFlagSupported / ZeCopyOffloadListFlagSupported),
ZeCopyOffloadExtensionSupported is set during platform initialization
but never read anywhere in any conditional logic. It only flowed
through: platform.cpp (probed from the driver's extension list) ->
context.cpp (passed to command_list_cache_t's constructor) ->
command_list_cache.hpp/cpp (stored as a class member), without
affecting behavior.
Remove the flag and its now-pointless extension name/version probing
block across platform.hpp/.cpp, context.cpp, and
command_list_cache.hpp/.cpp. No behavior change; the
ur_zex_intel_queue_copy_operations_offload_hint_exp_desc_t descriptor
and its pNext fallback usage are unrelated and unaffected.