Open
Conversation
wpietka
force-pushed
the
wpietkax/add-gemma-quantization-test
branch
3 times, most recently
from
3385be8 to
b07f4ff
Compare
Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
anko-intel
reviewed
May 4, 2026
|
|
||
|
|
||
| @pytest.mark.parametrize("dynamic", [True, False], ids=["dynamic=True", "dynamic=False"]) | ||
| def test_image_recognition(colva_beach_sq, model_dtype, quantization_dtype, dynamic): |
Contributor
There was a problem hiding this comment.
gemma3_instruct_4b-v1 is originally given in bfloat, so using float doesn't increase accuracy and should reduce significantly reduce time consumed by test, please use bfloat here
Signed-off-by: Wojciech Piętka <wojciechx.pietka@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Test
Description
Adds a new tests which quantize gemma3 model and run it with both text-only and image containing prompt
Expected Behavior & Potential Risk
E2E validation of Gemma3 output
How has this PR been tested?
pytest test/jax/test_gemma3_model.py
Dependency Change?
No dependencies changed