Skip to content

EISW-197119, EISW-197045, EISW-197080: Document import method transition in OVCore::ImportModel#931

Merged
MayureshV1 merged 3 commits into
masterfrom
copilot/add-comment-to-ov-interface
Feb 5, 2026
Merged

EISW-197119, EISW-197045, EISW-197080: Document import method transition in OVCore::ImportModel#931
MayureshV1 merged 3 commits into
masterfrom
copilot/add-comment-to-ov-interface

Conversation

Copilot AI commented Feb 5, 2026

Copy link
Copy Markdown

Description

Adds inline documentation to OVCore::ImportModel clarifying the import strategy introduced in PR #891:

// Import from tensor enables file mapping and should be used as primary option. 
// Import from stream is only used for OV versions prior to OV25.3.
// TODO: Remove import from stream when OV26.0 support is added and OV 2025.2 support is removed.
#if (OPENVINO_VERSION_MAJOR > 2025 || (OPENVINO_VERSION_MAJOR == 2025 && OPENVINO_VERSION_MINOR >= 3))

The comment precedes the conditional compilation block choosing between tensor-based import (primary, enables file mapping) and stream-based import (legacy fallback for OV <2025.3).

Motivation and Context

PR #891 introduced version-dependent import logic without documenting the deprecation timeline. This comment provides maintainers with the migration path for future OpenVINO version transitions.

Original prompt

Use this PR https://github.com/intel/onnxruntime/pull/891/changes
and add a commit that adds a comment in ov_interface.cc before if loop to notify developers mentioning
"Import from tensor enables file mapping and should be used as primary option. Import from stream is only used for OV versions prior to OV25.3.
Todo: Remove import from stream when OV26.0 support is added and OV 2025.2 support is removed."


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits February 5, 2026 19:49
Co-authored-by: MayureshV1 <47039074+MayureshV1@users.noreply.github.com>
Co-authored-by: MayureshV1 <47039074+MayureshV1@users.noreply.github.com>
Copilot AI changed the title [WIP] Add comment to ov_interface.cc for import options Add developer comment documenting import method transition in OVCore::ImportModel Feb 5, 2026
Copilot AI requested a review from MayureshV1 February 5, 2026 19:52
Copilot AI changed the title Add developer comment documenting import method transition in OVCore::ImportModel Document import method transition in OVCore::ImportModel Feb 5, 2026
@MayureshV1 MayureshV1 requested a review from ericcraw February 5, 2026 20:27
@MayureshV1 MayureshV1 marked this pull request as ready for review February 5, 2026 20:28
@MayureshV1 MayureshV1 changed the title Document import method transition in OVCore::ImportModel EISW-197119, EISW-197045, EISW-197080: Document import method transition in OVCore::ImportModel Feb 5, 2026
@MayureshV1

Copy link
Copy Markdown

FYI.. @n1harika , @preetha-intel

@MayureshV1 MayureshV1 merged commit 35f0afa into master Feb 5, 2026
1 of 2 checks passed
@MayureshV1 MayureshV1 deleted the copilot/add-comment-to-ov-interface branch February 5, 2026 21:56
Copilot AI added a commit that referenced this pull request Feb 5, 2026
…ion in OVCore::ImportModel (#931)

* Initial plan

* Add comment to notify developers about import from tensor vs stream

Co-authored-by: MayureshV1 <47039074+MayureshV1@users.noreply.github.com>

* Capitalize TODO in comment to follow standard convention

Co-authored-by: MayureshV1 <47039074+MayureshV1@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MayureshV1 <47039074+MayureshV1@users.noreply.github.com>
MayureshV1 added a commit that referenced this pull request Feb 6, 2026
…ion in OVCore::ImportModel (#935)

* Initial plan

* EISW-197119, EISW-197045, EISW-197080: Document import method transition in OVCore::ImportModel (#931)

* Initial plan

* Add comment to notify developers about import from tensor vs stream

Co-authored-by: MayureshV1 <47039074+MayureshV1@users.noreply.github.com>

* Capitalize TODO in comment to follow standard convention

Co-authored-by: MayureshV1 <47039074+MayureshV1@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MayureshV1 <47039074+MayureshV1@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MayureshV1 <47039074+MayureshV1@users.noreply.github.com>
jatinwadhwa921 added a commit that referenced this pull request Feb 6, 2026
… transition in OVCore::ImportModel (#931)"

This reverts commit 35f0afa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants