Skip to content

Ignore unknown SPIR-V extensions in --spirv-ext= flag #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenju-he merged 1 commit into from
Jan 20, 2026
Merged

Ignore unknown SPIR-V extensions in --spirv-ext= flag #634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions options_compile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,11 @@ static int parseSPVExtOption(
llvm::SmallVector<llvm::StringRef, 32> SPVExtList;
llvm::SplitString(SPVExt, SPVExtList, ",");

if (SPVExtList.empty())
return 0; // Nothing to do
if (SPVExtList.empty()) {
llvm::errs() << "Invalid value of --spirv-ext, expected format is:\n"
<< "\t--spirv-ext=+EXT_NAME,-EXT_NAME\n";
return -1;
}

for (unsigned i = 0; i < SPVExtList.size(); ++i) {
llvm::StringRef ExtString = SPVExtList[i];
Expand All @@ -121,14 +124,11 @@ static int parseSPVExtOption(
for (const auto &It : ExtensionNamesMap)
ExtensionsStatus[It.second] = ExtStatus;
} else {
// Reject unknown extensions
// Ignore unknown extensions, as targets may support non-standard SPIR-V
// extensions. Do not reject them; this approach is more tolerant.
const auto &It = ExtensionNamesMap.find(ExtName);
if (ExtensionNamesMap.end() == It) {
llvm::errs() << "Unknown extension '" << ExtName
<< "' was specified via "
<< "--spirv-ext option\n";
return -1;
}
if (ExtensionNamesMap.end() == It)
continue;

ExtensionsStatus[It->second] = ExtStatus;
}
Expand Down
Loading