Skip to content

Fix SPIRV-LLVM-Translator header file path in out-of-tree build#649

Merged
wenju-he merged 3 commits intointel:ocl-open-200from
wenju-he:20-fix-out-of-tree-build
Feb 24, 2026
Merged

Fix SPIRV-LLVM-Translator header file path in out-of-tree build#649
wenju-he merged 3 commits intointel:ocl-open-200from
wenju-he:20-fix-out-of-tree-build

Conversation

@wenju-he
Copy link
Copy Markdown
Contributor

Changes:

  • Upgrade Ubuntu version to 24.04
  • Switch legacy 'apt-key add -' to /etc/apt/keyrings/llvm.gpg
  • Prepend SPIRV-LLVM-Translator header file path with LLVMSPIRVLib

Resolves #646

Changes:
* Upgrade Ubuntu version to 24.04
* Switch legacy 'apt-key add -' to /etc/apt/keyrings/llvm.gpg
* Prepend SPIRV-LLVM-Translator header file path with LLVMSPIRVLib

Resolves intel#646
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes out-of-tree builds against separately packaged LLVM + SPIRV-LLVM-Translator by adjusting SPIRV-LLVM-Translator include paths for the prebuilt-LLVM configuration, and updates CI workflows to use Ubuntu 24.04 and modern LLVM apt repository key handling.

Changes:

  • Update options.h / options_compile.cpp to include SPIRV-LLVM-Translator headers from LLVMSPIRVLib/... when USE_PREBUILT_LLVM is defined.
  • Update GitHub Actions workflows to run on Ubuntu 24.04 and replace deprecated apt-key usage with /etc/apt/keyrings/llvm.gpg.
  • Fix workflow env var naming for SPIRV_TRANSLATOR_DIR by switching to an underscore-based variable name.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
options.h Adjusts SPIRV-LLVM-Translator header include path for prebuilt-LLVM builds.
options_compile.cpp Adjusts .inc include path for SPIRV extension table in prebuilt-LLVM builds.
.github/workflows/on-push-verification-out-of-tree.yml Moves CI to ubuntu-24.04, updates LLVM apt key setup, and fixes env var naming.
.github/workflows/codeql.yml Moves CodeQL job to ubuntu-24.04 and updates LLVM apt key setup and env var naming.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/on-push-verification-out-of-tree.yml
Comment thread .github/workflows/codeql.yml
wenju-he and others added 2 commits February 15, 2026 10:20
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@wenju-he wenju-he requested a review from cdai2 February 15, 2026 02:29
@wenju-he wenju-he merged commit 0ab33d6 into intel:ocl-open-200 Feb 24, 2026
4 checks passed
@wenju-he wenju-he deleted the 20-fix-out-of-tree-build branch February 24, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants