Fix SPIRV-LLVM-Translator header file path in out-of-tree build#649
Merged
wenju-he merged 3 commits intointel:ocl-open-200from Feb 24, 2026
Merged
Fix SPIRV-LLVM-Translator header file path in out-of-tree build#649wenju-he merged 3 commits intointel:ocl-open-200from
wenju-he merged 3 commits intointel:ocl-open-200from
Conversation
Changes: * Upgrade Ubuntu version to 24.04 * Switch legacy 'apt-key add -' to /etc/apt/keyrings/llvm.gpg * Prepend SPIRV-LLVM-Translator header file path with LLVMSPIRVLib Resolves intel#646
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes out-of-tree builds against separately packaged LLVM + SPIRV-LLVM-Translator by adjusting SPIRV-LLVM-Translator include paths for the prebuilt-LLVM configuration, and updates CI workflows to use Ubuntu 24.04 and modern LLVM apt repository key handling.
Changes:
- Update
options.h/options_compile.cppto include SPIRV-LLVM-Translator headers fromLLVMSPIRVLib/...whenUSE_PREBUILT_LLVMis defined. - Update GitHub Actions workflows to run on Ubuntu 24.04 and replace deprecated
apt-keyusage with/etc/apt/keyrings/llvm.gpg. - Fix workflow env var naming for
SPIRV_TRANSLATOR_DIRby switching to an underscore-based variable name.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| options.h | Adjusts SPIRV-LLVM-Translator header include path for prebuilt-LLVM builds. |
| options_compile.cpp | Adjusts .inc include path for SPIRV extension table in prebuilt-LLVM builds. |
| .github/workflows/on-push-verification-out-of-tree.yml | Moves CI to ubuntu-24.04, updates LLVM apt key setup, and fixes env var naming. |
| .github/workflows/codeql.yml | Moves CodeQL job to ubuntu-24.04 and updates LLVM apt key setup and env var naming. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
cdai2
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Resolves #646