Fix SPIRV-LLVM-Translator header file path in out-of-tree build#650
Merged
wenju-he merged 1 commit intointel:ocl-open-190from Feb 24, 2026
Merged
Conversation
Changes: * Upgrade Ubuntu version to 24.04 * Switch legacy 'apt-key add -' to /etc/apt/keyrings/llvm.gpg * Prepend SPIRV-LLVM-Translator header file path with LLVMSPIRVLib Resolves intel#646
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a build issue when using prebuilt LLVM and SPIRV-LLVM-Translator (out-of-tree build) by correcting header file include paths. The PR also modernizes the GitHub Actions workflows by upgrading to Ubuntu 24.04 and updating the deprecated apt key management approach.
Changes:
- Fixed SPIRV-LLVM-Translator header include paths in out-of-tree builds by adding
LLVMSPIRVLib/prefix whenUSE_PREBUILT_LLVMis defined - Upgraded CI workflows from Ubuntu 22.04 to 24.04 for out-of-tree and CodeQL builds
- Modernized apt key management from deprecated
apt-key addto/etc/apt/keyrings/llvm.gpgapproach - Fixed environment variable naming from
spirv-translator-dirtospirv_translator_install_dir(using underscores instead of hyphens)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| options.h | Added conditional include for LLVMSPIRVOpts.h with LLVMSPIRVLib/ prefix when using prebuilt LLVM |
| options_compile.cpp | Added conditional include for LLVMSPIRVExtensions.inc with LLVMSPIRVLib/ prefix when using prebuilt LLVM |
| .github/workflows/on-push-verification-out-of-tree.yml | Updated to Ubuntu 24.04, modernized apt key management, and fixed environment variable naming |
| .github/workflows/codeql.yml | Updated to Ubuntu 24.04, modernized apt key management, and fixed environment variable naming |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cdai2
approved these changes
Feb 24, 2026
wenju-he
added a commit
to wenju-he/opencl-clang
that referenced
this pull request
Mar 17, 2026
wenju-he
added a commit
to wenju-he/opencl-clang
that referenced
this pull request
Mar 17, 2026
wenju-he
added a commit
to wenju-he/opencl-clang
that referenced
this pull request
Mar 17, 2026
wenju-he
added a commit
that referenced
this pull request
Mar 17, 2026
wenju-he
added a commit
that referenced
this pull request
Mar 17, 2026
wenju-he
added a commit
that referenced
this pull request
Mar 17, 2026
wenju-he
added a commit
that referenced
this pull request
Mar 17, 2026
wenju-he
added a commit
that referenced
this pull request
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Resolves #646