Skip to content

Fix SPIRV-LLVM-Translator header file path in out-of-tree build#650

Merged
wenju-he merged 1 commit intointel:ocl-open-190from
wenju-he:19-fix-out-of-tree-build
Feb 24, 2026
Merged

Fix SPIRV-LLVM-Translator header file path in out-of-tree build#650
wenju-he merged 1 commit intointel:ocl-open-190from
wenju-he:19-fix-out-of-tree-build

Conversation

@wenju-he
Copy link
Copy Markdown
Contributor

Changes:

  • Upgrade Ubuntu version to 24.04
  • Switch legacy 'apt-key add -' to /etc/apt/keyrings/llvm.gpg
  • Prepend SPIRV-LLVM-Translator header file path with LLVMSPIRVLib

Resolves #646

Changes:
* Upgrade Ubuntu version to 24.04
* Switch legacy 'apt-key add -' to /etc/apt/keyrings/llvm.gpg
* Prepend SPIRV-LLVM-Translator header file path with LLVMSPIRVLib

Resolves intel#646
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a build issue when using prebuilt LLVM and SPIRV-LLVM-Translator (out-of-tree build) by correcting header file include paths. The PR also modernizes the GitHub Actions workflows by upgrading to Ubuntu 24.04 and updating the deprecated apt key management approach.

Changes:

  • Fixed SPIRV-LLVM-Translator header include paths in out-of-tree builds by adding LLVMSPIRVLib/ prefix when USE_PREBUILT_LLVM is defined
  • Upgraded CI workflows from Ubuntu 22.04 to 24.04 for out-of-tree and CodeQL builds
  • Modernized apt key management from deprecated apt-key add to /etc/apt/keyrings/llvm.gpg approach
  • Fixed environment variable naming from spirv-translator-dir to spirv_translator_install_dir (using underscores instead of hyphens)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
options.h Added conditional include for LLVMSPIRVOpts.h with LLVMSPIRVLib/ prefix when using prebuilt LLVM
options_compile.cpp Added conditional include for LLVMSPIRVExtensions.inc with LLVMSPIRVLib/ prefix when using prebuilt LLVM
.github/workflows/on-push-verification-out-of-tree.yml Updated to Ubuntu 24.04, modernized apt key management, and fixed environment variable naming
.github/workflows/codeql.yml Updated to Ubuntu 24.04, modernized apt key management, and fixed environment variable naming

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wenju-he wenju-he requested a review from cdai2 February 15, 2026 02:29
@wenju-he wenju-he merged commit a9c93e8 into intel:ocl-open-190 Feb 24, 2026
10 checks passed
@wenju-he wenju-he deleted the 19-fix-out-of-tree-build branch February 24, 2026 08:30
wenju-he added a commit to wenju-he/opencl-clang that referenced this pull request Mar 17, 2026
…l#650)

Changes:
* Upgrade Ubuntu version to 24.04
* Switch legacy 'apt-key add -' to /etc/apt/keyrings/llvm.gpg
* Prepend SPIRV-LLVM-Translator header file path with LLVMSPIRVLib

Resolves intel#646

(cherry picked from commit a9c93e8)
wenju-he added a commit to wenju-he/opencl-clang that referenced this pull request Mar 17, 2026
…l#650)

Changes:
* Upgrade Ubuntu version to 24.04
* Switch legacy 'apt-key add -' to /etc/apt/keyrings/llvm.gpg
* Prepend SPIRV-LLVM-Translator header file path with LLVMSPIRVLib

Resolves intel#646

(cherry picked from commit a9c93e8)
(cherry picked from commit ec4a45b)
wenju-he added a commit to wenju-he/opencl-clang that referenced this pull request Mar 17, 2026
…l#650)

Prepend SPIRV-LLVM-Translator header file path with LLVMSPIRVLib

Resolves intel#646

(cherry picked from commit ec4a45b)
wenju-he added a commit to wenju-he/opencl-clang that referenced this pull request Mar 17, 2026
…l#650)

Prepend SPIRV-LLVM-Translator header file path with LLVMSPIRVLib

Resolves intel#646

(cherry picked from commit ec4a45b)
wenju-he added a commit to wenju-he/opencl-clang that referenced this pull request Mar 17, 2026
…l#650)

Prepend SPIRV-LLVM-Translator header file path with LLVMSPIRVLib

Resolves intel#646

(cherry picked from commit ec4a45b)
wenju-he added a commit that referenced this pull request Mar 17, 2026
…-tree build (#650) (#656)

Prepend SPIRV-LLVM-Translator header file path with LLVMSPIRVLib

Resolves #646

(cherry picked from commit a9c93e8)
wenju-he added a commit that referenced this pull request Mar 17, 2026
…-tree build (#650) (#657)

Prepend SPIRV-LLVM-Translator header file path with LLVMSPIRVLib

Resolves #646

(cherry picked from commit ec4a45b)
wenju-he added a commit that referenced this pull request Mar 17, 2026
…-tree build (#650) (#658)

Prepend SPIRV-LLVM-Translator header file path with LLVMSPIRVLib

Resolves #646

(cherry picked from commit ec4a45b)
wenju-he added a commit that referenced this pull request Mar 17, 2026
…-tree build (#650) (#659)

Prepend SPIRV-LLVM-Translator header file path with LLVMSPIRVLib

Resolves #646

(cherry picked from commit ec4a45b)
wenju-he added a commit that referenced this pull request Mar 17, 2026
…-tree build (#650) (#660)

Prepend SPIRV-LLVM-Translator header file path with LLVMSPIRVLib

Resolves #646

(cherry picked from commit ec4a45b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants