Fix bug with None dart_command during interactive debug with no timeout
#49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
When
Noneis passed fordart_commandin order to perform interactive debug of the Dart process in cosimulation with the SystemVerilog simulator, there was a bug where the timeout variable was still used even if it was set toNoneas well. This caused a crash in python.This PR
dart_command = Noneanddart_connect_timeout = Noneworks properly with therohd_port_connector.pyextractSocketPortfunction onCosimConnectionso that it can be reused to extract port information from the stdout of the cosimulation processRelated Issue(s)
N/A
Testing
Added new tests, existing tests cover things
Backwards-compatibility
No, just bug fixes, API improvements, and error logging enhancements
Documentation
No, API docs are minorly updated