Unit tests for LOAD_2D and STORE_2D #582
Open
+302
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishi-yadav
added
the
Tests
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive unit tests for the Intel XE block 2D copy operations (XE_LOAD_2D and XE_STORE_2D). The tests validate these operations across 11 different data types with 7 height variations each, totaling 77 test configurations.
Key changes:
- Added new test file
xe_copy_2d_test.cppwith device kernel and host test infrastructure for 2D copy validation - Updated version check guard in
mma.cppto handle IGC version 2.18+ more robustly and added fallback test for older versions - Integrated new test file into the build system via CMakeLists.txt
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/unit/cute/intel_xe/xe_copy_2d_test.cpp | Implements test infrastructure including kernel, test function template, and 11 test cases covering various data types |
| test/unit/cute/intel_xe/mma.cpp | Improves version check logic and adds fallback test case for IGC versions below 2.18 |
| test/unit/cute/intel_xe/CMakeLists.txt | Registers xe_copy_2d_test.cpp in the build configuration |
Comments suppressed due to low confidence (1)
test/unit/cute/intel_xe/mma.cpp:153
- Missing #endif to close the preprocessor conditional block opened at line 315.
#endif
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * modification, are permitted provided that the following conditions are met: | ||
| * | ||
| * 1. Redistributions of source code must retain the above copyright notice, this | ||
| * list of conditions and the disclaimer. |
There was a problem hiding this comment.
Corrected 'disclaimer' to 'following disclaimer' to match standard BSD-3-Clause license text.
Suggested change
| * list of conditions and the disclaimer. | |
| * list of conditions and the following disclaimer. |
| * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
| * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, | ||
| * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| * OF THIS SOFTWARE, EVEN IF ADVISED OF POSSIBILITY OF SUCH DAMAGE. |
There was a problem hiding this comment.
Corrected 'ADVISED OF POSSIBILITY' to 'ADVISED OF THE POSSIBILITY' to match standard BSD-3-Clause license text.
Suggested change
| * OF THIS SOFTWARE, EVEN IF ADVISED OF POSSIBILITY OF SUCH DAMAGE. | |
| * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
Antonyvance
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XE_LOAD_2D<Bits, Height, Width>XE_STORE_2D<Bits, Height, Width>11 test cases added for diff datatypes with 7 variations of height so total 77 variations used in this PR