Skip to content

Conversation

@CuiYifeng
Copy link
Contributor

This PR adds out-variant functions to the fallback list: cholesky.out, cholesky_inverse.out, geqrf.a, and ormqr.out, improving coverage for operations that produce output tensors.

Copilot AI review requested due to automatic review settings November 4, 2025 02:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances XPU fallback coverage by adding out-variant and named-variant function signatures to the fallback list. These additions ensure that operations with output tensor parameters have proper fallback implementations when XPU-native implementations are unavailable.

Key changes:

  • Added out-variant functions (cholesky.out, cholesky_inverse.out, ormqr.out) to complement their base function counterparts
  • Added named variant geqrf.a to complement the base geqrf function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@CuiYifeng
Copy link
Contributor Author

The following test cases will be fixed:

TestCommonXPU,test_out_cholesky_xpu_float32
TestCommonXPU,test_out_warning_cholesky_inverse_xpu
TestCommonXPU,test_out_warning_cholesky_xpu
TestCommonXPU,test_out_warning_geqrf_xpu
TestCommonXPU,test_out_warning_ormqr_xpu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NotImplementedError detected int test_ops.py

2 participants