-
Notifications
You must be signed in to change notification settings - Fork 70
Test #2771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Test #2771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a new GitHub Actions workflow for running XPU (Intel GPU) tests on the torchcomms repository. The workflow is designed to execute on pull requests and manual triggers, running tests in a containerized environment with XPU device access.
Changes:
- Added comprehensive XPU testing workflow with container-based test execution
- Implemented health checks for runner GPU availability and disk space
- Configured Docker container setup with XPU device access and proper permissions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/test_xpu.yml
Outdated
| working-directory: pytorch | ||
| run: | | ||
| DOCKER_BUILD_DIR=".ci/docker" | ||
| DOCKER_IMAGE_NAME=${${env.DOCKER_IMAGE}-}$(git rev-parse HEAD:"${DOCKER_BUILD_DIR}") |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid shell parameter expansion syntax. The expression ${${env.DOCKER_IMAGE}-} contains nested parameter expansions which is not valid in bash. This should be ${DOCKER_IMAGE:-} to provide an empty default value if DOCKER_IMAGE is unset.
| DOCKER_IMAGE_NAME=${${env.DOCKER_IMAGE}-}$(git rev-parse HEAD:"${DOCKER_BUILD_DIR}") | |
| DOCKER_IMAGE_NAME=${DOCKER_IMAGE:-}$(git rev-parse HEAD:"${DOCKER_BUILD_DIR}") |
.github/workflows/test_xpu.yml
Outdated
| with: | ||
| working-directory: pytorch |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'with' keyword is invalid for a run step. The 'with' keyword is used for action inputs, but this is a 'run' step executing shell commands. Remove the 'with' block or convert this to use an action that accepts working-directory as an input.
| with: | |
| working-directory: pytorch | |
| working-directory: pytorch |
.github/workflows/test_xpu.yml
Outdated
| --shm-size="8g" \ | ||
| --tty \ | ||
| --detach \ | ||
| --name="${container_name}" \ |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable 'container_name' is used before it is defined. The docker run command uses '--name="${container_name}"' but the output is assigned to container_name afterward. This will fail because the variable is empty when used. Remove the --name flag and let Docker generate a name, or generate the name before the docker run command.
| --name="${container_name}" \ |
.github/workflows/test_xpu.yml
Outdated
| -e JOB_ID \ | ||
| -e BRANCH \ | ||
| -e SHA1 \ | ||
| --user $(id -u):$(id -g) \ |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User is specified twice in the docker run command. Line 131 sets '--user
| --user $(id -u):$(id -g) \ |
19d33da to
1eedc5d
Compare
No description provided.