Add ldexp implementation on XPU #2773
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CuiYifeng
requested changes
Jan 27, 2026
Contributor
CuiYifeng
left a comment
CuiYifeng
left a comment
There was a problem hiding this comment.
@xiaowangintel Please check UT summary. I noticed that there are still ldexp related cases in failure list.
src/ATen/native/xpu/BinaryOps.cpp
Outdated
| REGISTER_XPU_DISPATCH( | ||
| shifted_chebyshev_polynomial_w_stub, | ||
| &xpu::shifted_chebyshev_polynomial_w_kernel); | ||
|
|
Contributor
There was a problem hiding this comment.
Please remove this blank line.
Contributor
Author
Sync with @daisyden , we need to execute ci first and ensure the relevant test pass. Then we can consider removing items from the failure list. |
CuiYifeng
reviewed
Jan 27, 2026
| template <typename scalar_t> | ||
| struct LdexpFunctor { | ||
| scalar_t operator()(scalar_t x, int exp) const { | ||
| return ::ldexp(x, exp); |
Contributor
There was a problem hiding this comment.
One more question: which component provides ::ldexp?
Performance outliers, please check!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2772
The ldexp's implementation have been changed in pytorch/pytorch#168357. The new implementation involves adding a stub kernel to replace the decomposition. And we meets error as 'DispatchStub: missing kernel for xpu' when use ldexp operator with stock pytorch.