Include core CachingHostAllocator.h instead of the XPU one#3981
Open
cyyever wants to merge 2 commits into
Open
Include core CachingHostAllocator.h instead of the XPU one#3981cyyever wants to merge 2 commits into
cyyever wants to merge 2 commits into
Conversation
Upstream ATen/xpu/CachingHostAllocator.h is now only deprecated inline wrappers around at::getHostAllocator(at::kXPU), which is declared in ATen/core/CachingHostAllocator.h. We call only the generic API, so include the core header directly (and drop the include entirely in Shape.cpp, which uses none of it). In Copy.cpp the include also leaves the SYCL warning-suppression block since the core header is host-only. Test Plan: Include-only change; verified no file references the deprecated at::xpu wrappers: ``` grep -rn "getCachingHostAllocator\|CachingHostAllocator_\|xpu::HostAlloc" src/ ``` Compile coverage relies on CI since this repo has no standalone build.
cyyever
force-pushed
the
agent/remove-xpu-caching-host-allocator-include
branch
from
cce3b10 to
400d85d
Compare
guangyey
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream ATen/xpu/CachingHostAllocator.h is now only deprecated inline wrappers around at::getHostAllocator(at::kXPU), which is declared in ATen/core/CachingHostAllocator.h. We call only the generic API, so include the core header directly (and drop the include entirely in Shape.cpp, which uses none of it). In Copy.cpp the include also leaves the SYCL warning-suppression block since the core header is host-only.
Authored with Claude Code.