Fix minor CMake issues#3982
Open
cyyever wants to merge 3 commits into
Open
Conversation
Cleanups from a CMake audit: the include-dir dedup in run_sycl.cmake referenced a misspelled variable and never ran; GNU ld's --start-group/--end-group were passed to MSVC link on Windows (ignored with warnings); FindONEMKL accepted *-NOTFOUND libraries and still reported success, deferring a partial oneMKL install to an obscure link error instead of failing at configure time. Also removes an undefined variable reference, a stray get_filename_component() argument, and a duplicated source listing, none of which affect the build output. Test Plan: Configure-time changes only. Checked with: ``` lintrunner --take CMAKE ``` and verified via a scratch `cmake -P` script that `get_filename_component(... NAME_WLE)` output is unchanged after dropping the stray REALPATH argument.
guangyey
reviewed
Jun 13, 2026
| NO_CMAKE_PATH NO_CMAKE_ENVIRONMENT_PATH) | ||
| if(NOT ${LIB_NAME}_library) | ||
| message(WARNING "${LIB_NAME} not found in ${ONEMKL_LIB_DIR}!!") | ||
| return() |
Contributor
There was a problem hiding this comment.
Good catch!
Could you help update
torch-xpu-ops/cmake/ONEMKL.cmake
Lines 22 to 24 in 8ca427a
"oneMKL not found or installation is incomplete; see warnings above for details."
guangyey
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanups from a CMake audit: the include-dir dedup in run_sycl.cmake referenced a misspelled variable and never ran; GNU ld's --start-group/--end-group were passed to MSVC link on Windows (ignored with warnings); FindONEMKL accepted *-NOTFOUND libraries and still reported success, deferring a partial oneMKL install to an obscure link error instead of failing at configure time. Also removes an undefined variable reference, a stray get_filename_component() argument, and a duplicated source listing, none of which affect the build output.
Authored with Claude Code.