Skip to content
This repository was archived by the owner on Sep 4, 2025. It is now read-only.

Conversation

@liuw1
Copy link
Contributor

@liuw1 liuw1 commented Apr 28, 2025

No description provided.

@liuw1 liuw1 requested a review from Copilot April 28, 2025 07:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the use of the unsafe paste crate from the project to improve code safety and clarity. Key changes include:

  • Removal of the paste dependency from Cargo.toml files in src/vtpmtd, src/tdtunnel, and src/spdm.
  • Replacement of paste-based macro rules in src/tdtunnel/src/interrupt.rs with explicit interrupt handler definitions.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
src/vtpmtd/Cargo.toml Removed the paste dependency.
src/tdtunnel/src/interrupt.rs Removed paste macro usage and introduced explicit constants and functions.
src/tdtunnel/Cargo.toml Removed the paste dependency.
src/spdm/Cargo.toml Removed the paste dependency.
Comments suppressed due to low confidence (2)

src/tdtunnel/src/interrupt.rs:26

  • [nitpick] The function name 'register_vmm_notification_wait_for_request' is quite verbose. Consider renaming it to a shorter, consistent name such as 'register_vmm_notification' if it aligns with the project conventions.
pub fn register_vmm_notification_wait_for_request() {

src/tdtunnel/src/interrupt.rs:34

  • [nitpick] The function name 'wait_for_vmm_notification_wait_for_request' is redundant and lengthy. A simpler name like 'wait_for_vmm_notification' might improve readability and consistency.
pub fn wait_for_vmm_notification_wait_for_request() {

@jyao1 jyao1 closed this Apr 28, 2025
@jyao1 jyao1 reopened this Apr 28, 2025
@liuw1 liuw1 requested a review from gaojiaqi7 April 28, 2025 08:17
@jyao1 jyao1 merged commit 00a2f86 into intel:main Apr 29, 2025
18 of 23 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants