Fix missing logo192.png reference. Closes #627 #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the apple-touch-icon link to reference the existing favicon.ico instead of the non-existent logo192.png file, resolving the 404 error when the frontend tries to load the missing asset. Fixes intelowlproject#627
Collaborator
|
Thanks for your contribution! :) The name of the missing file suggests that an image of size 192x192 is required. The favicon is 512x512. Do you think that's a problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frontend's
index.htmlfile referenced a non-existentlogo192.pngfile for the Apple Touch Icon. This PR updates the reference to use the existingfavicon.icofile instead, eliminating the 404 error that occurs when browsers attempt to load the missing asset.Related issues
Fixes #627
Type of change
Checklist
develop.Black,Flake,Isort) gave 0 errors. (N/A - HTML only change, no Python/JS code modified)