feat: improve generic observable type detection in InQuest analyzer#3283
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves IntelOwl’s InQuest observable analyzer by enhancing type_of_generic() so it can automatically infer more generic observable types beyond just email vs filename, and adds unit tests to validate the new detection logic.
Changes:
- Expanded generic observable detection to identify emails (incl. subdomains/long TLDs), registry keys, and UUID-like XMP IDs.
- Added basic filename validation and warning logging when the type can’t be confidently inferred.
- Added unit tests covering the new
type_of_generic()behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
api_app/analyzers_manager/observable_analyzers/inquest.py |
Improves generic observable type inference (email/registry/xmpid/filename) and logs a warning on fallback. |
tests/api_app/analyzers_manager/unit_tests/observable_analyzers/test_inquest.py |
Adds a dedicated test case class validating type_of_generic() for the new patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/api_app/analyzers_manager/unit_tests/observable_analyzers/test_inquest.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/api_app/analyzers_manager/unit_tests/observable_analyzers/test_inquest.py
Show resolved
Hide resolved
|
Hi @mlodic, The PR is ready for review. PTAL when you get time. Thanks! |
|
please show screenshot and json result of an analysis with at least one of this cases then we are ready to merge |
Hi @mlodic , I have verified the changes. Here are screenshot and json result, I have added uuid as observable, and got xmpid in |
…ntelowlproject#3283) * feat: improve generic observable type detection in InQuest analyzer * refactor: precompile regex patterns and improve test robustness * refactored the XMPID_PATTERN regex and added a test for logging a warning

Description
Improved the type_of_generic() method in the InQuest analyzer to provide more thorough validation of generic observable types.
Closes #3280
Changes Made
HKEY_*,HKLM,HKCU, etc.Type of change
Checklist
developBlack,Flake,Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.testsfolder). All the tests (new and old ones) gave 0 errors.