Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes UserEventQuerySet.decay() to reduce per-row database updates and to make the decay operation atomic, adding tests to validate reduced query counts and rollback behavior.
Changes:
- Reworked
UserEventQuerySet.decay()to prefetch relateddata_modelobjects and apply updates viabulk_update()inside a transaction. - Added a test asserting reduced query counts for bulk decay.
- Added a test asserting atomic rollback if the bulk update fails.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
api_app/user_events_manager/queryset.py |
Implements bulk/atomic decay logic and related object fetching strategy. |
tests/api_app/user_events_manager/test_queryset.py |
Adds tests for query-count reduction and transaction rollback safety. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@mlodic please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3248
Description
Optimized decay() with bulk updates and atomic transaction in queryset.py.
Added tests covering query count reduction and rollback safety in test_queryset.py.
Type of change
Please delete options that are not relevant.