Skip to content

fix: handle SSL and DNS errors gracefully in DNStwist analyzer. Close #3282 #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NikhilRaikwar wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: handle SSL and DNS errors gracefully in DNStwist analyzer. Close #3282 #3290

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04b5c42
fix: handle SSL and DNS errors gracefully in DNStwist analyzer. Close…
NikhilRaikwar Feb 7, 2026
40f182b
test: add unit tests for DNStwist error handling
NikhilRaikwar Feb 7, 2026
1b3ae3a
fix(dnstwist): remove catch-all exception block as requested
NikhilRaikwar Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion api_app/analyzers_manager/observable_analyzers/dnstwist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# See the file 'LICENSE' for copying permission.

import logging
import ssl
from ipaddress import AddressValueError, IPv4Address
from urllib.parse import urlparse

Expand Down Expand Up @@ -55,6 +56,11 @@ def run(self):
if self.user_agent:
params["useragent"] = self.user_agent

report = dnstwist.run(**params)
try:
report = dnstwist.run(**params)
except (OSError, ssl.SSLError) as e:
return {"error": f"Network/SSL error: {str(e)}"}
except Exception as e:
Copy link
Member

@mlodic mlodic Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unexpected errors should still make the analyzer fail so please remove this.

Here we want to manage the errors that are not caused by the tool itself but are based on the input data based on the current observations that we reported in the issue.

Copy link
Contributor Author

@NikhilRaikwar NikhilRaikwar Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the catch-all Exception block in the latest commit.

return {"error": f"Unexpected error: {str(e)}"}

return report
40 changes: 40 additions & 0 deletions tests/api_app/analyzers_manager/unit_tests/observable_analyzers/test_dnstwist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,43 @@ def get_extra_config(cls) -> dict:
"user_agent": "IntelOwl-Test",
"nameservers": "8.8.8.8,8.8.4.4",
}

def test_run_with_ssl_error(self):
import ssl

from api_app.analyzers_manager.models import AnalyzerConfig
from api_app.choices import Classification

config = AnalyzerConfig.objects.filter(name="DNStwist").first()
analyzer = self._setup_analyzer(config, Classification.DOMAIN, "example.com")

with patch("dnstwist.run", side_effect=ssl.SSLEOFError("EOF occurred in violation of protocol")):
report = analyzer.run()
self.assertIn("error", report)
self.assertTrue(report["error"].startswith("Network/SSL error"))

def test_run_with_dns_error(self):
import socket

from api_app.analyzers_manager.models import AnalyzerConfig
from api_app.choices import Classification

config = AnalyzerConfig.objects.filter(name="DNStwist").first()
analyzer = self._setup_analyzer(config, Classification.DOMAIN, "example.com")

with patch("dnstwist.run", side_effect=socket.gaierror(-2, "Name or service not known")):
report = analyzer.run()
self.assertIn("error", report)
self.assertTrue(report["error"].startswith("Network/SSL error"))

def test_run_with_unexpected_error(self):
from api_app.analyzers_manager.models import AnalyzerConfig
from api_app.choices import Classification

config = AnalyzerConfig.objects.filter(name="DNStwist").first()
analyzer = self._setup_analyzer(config, Classification.DOMAIN, "example.com")

with patch("dnstwist.run", side_effect=Exception("Something went wrong")):
report = analyzer.run()
self.assertIn("error", report)
self.assertTrue(report["error"].startswith("Unexpected error"))
Loading