refactor(BuilderForm): don't split content/appearance#368
Merged
Conversation
sidvishnoi
force-pushed
the
do-not-split-content-appearance
branch
from
c81325f to
436d889
Compare
Deployment results
Logs #18198218672 |
sidvishnoi
changed the title
sidvishnoi
changed the title
sidvishnoi
commented
Sep 30, 2025
Keep a single `profile` object, that'll eventually map one-to-one with the config saved in the database.
sidvishnoi
force-pushed
the
do-not-split-content-appearance
branch
from
436d889 to
829e3d0
Compare
kjmitchelljr
approved these changes
Oct 1, 2025
Collaborator
kjmitchelljr
left a comment
kjmitchelljr
left a comment
There was a problem hiding this comment.
Changes look to be straightforward 👍🏿
DarianM
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't split
contentandappearanceconfig values when editing in two different sections. Instead, pass the singleprofilestore to editors.Keeping a single profile object, that'll eventually map one-to-one with the config saved in the database, will help with #302, #307.
Keeping the types separate now to avoid making large changes.