Conversation
sidvishnoi
reviewed
Oct 1, 2025
sidvishnoi
reviewed
Oct 1, 2025
sidvishnoi
reviewed
Oct 1, 2025
Deployment results
Logs #21173096970 |
DarianM
changed the title
sidvishnoi
reviewed
Jan 19, 2026
sidvishnoi
reviewed
Jan 19, 2026
sidvishnoi
reviewed
Jan 19, 2026
sidvishnoi
reviewed
Jan 19, 2026
sidvishnoi
reviewed
Jan 19, 2026
sidvishnoi
reviewed
Jan 20, 2026
sidvishnoi
approved these changes
Jan 20, 2026
Member
sidvishnoi
left a comment
sidvishnoi
left a comment
There was a problem hiding this comment.
One small suggestion, but LGTM! 
Comment on lines
+84
to
+86
| WORKFLOW_CHANGED=$(echo "$CHANGED_FILES" | grep -qE '^\.github/workflows/(deploy\.yml|deploy-worker/)' && echo true || echo false) | ||
| API_CHANGED=$(echo "$CHANGED_FILES" | grep -qE '^api/' && echo true || echo false) | ||
| SHARED_CHANGED=$(echo "$CHANGED_FILES" | grep -qE '^shared/' && echo true || echo false) |
Member
There was a problem hiding this comment.
Would suggest merging WORKFLOW_CHANGED and SHARED_CHANGED (as workflow is like a shared file), and then we won't have to check both WORKFLOW and SHARED for each api/cdn/frontend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Maintainers can trigger deployments preview by reviewing with
ok-to-deploydorny/paths-filter@v3action does not support thepull_request_reviewevent issue #232Work around, changes implement a manual file change detection using
git difffor review-triggered deployments.Triggered when changes are made to the following file patterns:
API deployment
.github/workflows/deploy.yml.github/workflows/deploy-worker/**api/**shared/**CDN deployment
.github/workflows/deploy.yml.github/workflows/deploy-worker/**api/**- API source code (/cdndepends on API)shared/**components/**cdn/**Frontend deployment
.github/workflows/deploy.yml.github/workflows/deploy-worker/**api/**shared/**components/**cdn/**- CDN worker (/frontenddepends on CDN)frontend/**Note: deploy.yml matches the pattern ^.github/workflows/deploy.yml, all three conditions evaluate to true, causing all modules to deploy on deploy.yml changes.