Skip to content

fix(revshare/ui): replace remove recipient icon #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DarianM merged 5 commits into from
Oct 3, 2025
Merged

fix(revshare/ui): replace remove recipient icon #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6528a96
Change last column from Delete → Remove, icon from trash to X & padding
suhaibfida Oct 2, 2025
4f3ca7a
Merge branch 'main' into feature
suhaibfida Oct 2, 2025
0b2458c
change stroke width
DarianM Oct 3, 2025
1f8f1ed
update name
DarianM Oct 3, 2025
613e2e7
Rename aria-labelledby name
DarianM Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion frontend/app/assets/svg.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,10 @@ export const SVGDeleteScript: SvgIcon = ({ className }) => (
<svg {...defaultProps} className={className} viewBox="0 0 20 20">
<path
fill="#7469A8"
d="M12.404 14.585v-.833h2.5v.833h-2.5Zm0-6.667v-.833h5v.833h-5Zm0 3.334v-.834h4.167v.834h-4.167ZM3.429 6.668h-.833v-.833h3.109v-.737H7.82v.737h3.11v.833h-.833v6.988c0 .383-.13.704-.386.96a1.301 1.301 0 0 1-.961.386H4.775c-.383 0-.703-.129-.96-.385a1.304 1.304 0 0 1-.385-.961l-.001-6.988Zm.833 0v6.988a.49.49 0 0 0 .161.352c.107.108.225.161.352.16H8.75a.492.492 0 0 0 .352-.16.491.491 0 0 0 .161-.353V6.668h-5Z"
d="M5 5 L15 15 M15 5 L5 15"
stroke="#7469A8"
strokeWidth="1"
strokeLinecap="round"
/>
</svg>
)
12 changes: 6 additions & 6 deletions frontend/app/components/redesign/components/revshare/ShareInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,10 @@ export const ShareInputHeader = ({ showDelete }: { showDelete: boolean }) => {
{showDelete && (
<div
role="columnheader"
id="col-delete"
aria-label="Delete recipient from table"
id="col-remove"
aria-label="Remove recipient from table"
>
Delete
Remove
</div>
)}
</div>
Expand Down Expand Up @@ -159,7 +159,7 @@ export const ShareInput = React.memo(
{showDelete && (
<ToolsSecondaryButton
onClick={onRemove}
className="border-none py-sm px-xs shrink-0"
className="border-none p-xs shrink-0"
aria-label="Remove recipient"
aria-describedby={pointerInputId}
>
Expand Down Expand Up @@ -273,11 +273,11 @@ export const ShareInput = React.memo(
<div
role="cell"
className="hidden md:block"
aria-labelledby="col-delete"
aria-labelledby="col-remove"
>
<ToolsSecondaryButton
onClick={onRemove}
className="border-none py-sm px-xs shrink-0"
className="border-none p-xs shrink-0"
aria-label="Remove recipient"
aria-describedby={pointerInputId}
>
Expand Down
Loading