Skip to content

docs: Improve and expand project documentation#398

Merged
DarianM merged 17 commits intointerledger:mainfrom
p-retrover:docs/improve-env-vars-guide
Oct 16, 2025
Merged

docs: Improve and expand project documentation#398
DarianM merged 17 commits intointerledger:mainfrom
p-retrover:docs/improve-env-vars-guide

Conversation

@p-retrover
Copy link
Copy Markdown
Contributor

Hi there! This PR is for Hacktoberfest and aims to make the project easier to understand for new contributors by improving existing documentation and adding new README.md files for the core packages.

Summary of Changes:

  • Improved docs/env-vars.md

    • The setup guide for environment variables was restructured to be more beginner-friendly.
    • A summary table was added for a quick overview.
    • Instructions were clarified with better examples.
  • Added Package-Level READMEs

    • Created a new README.md for the api package, explaining its endpoints and scripts.
    • Created a new README.md for the frontend package, explaining its features and scripts.
    • Created a new README.md for the components package, clarifying its role and build process.
    • Created a new README.md for the cdn package, explaining how the final assets are built and delivered.

These changes are all self-contained within documentation files and do not alter any application code. Thank you for your consideration!

The setup guide for environment variables has been updated to be more clear and beginner-friendly.

This commit introduces the following improvements:
- Adds a summary table for a quick overview of all variables.
- Provides a clear example for creating the `OP_WALLET_ADDRESS`.
- Restructures the document to improve scannability and clarity for new contributors.
Comment thread api/README.md Outdated
Comment thread api/README.md Outdated
Comment thread cdn/README.md
Comment thread components/README.md Outdated
Comment thread docs/env-vars.md Outdated
Comment thread frontend/README.md Outdated
p-retrover and others added 3 commits October 9, 2025 13:47
Co-authored-by: Sid Vishnoi <8426945+sidvishnoi@users.noreply.github.com>
- Remove redundant script commands from package READMEs

- Clarify that components are used by the frontend for demos

- Mention fonts and assets in the cdn README

- Remove semicolons from code examples in env-vars.md
@p-retrover
Copy link
Copy Markdown
Contributor Author

Please check if all the issues have been resolved. and thank you again for suggestions.

@sidvishnoi sidvishnoi requested a review from DarianM October 9, 2025 13:35
Comment thread docs/env-vars.md Outdated
Comment thread docs/env-vars.md Outdated
Comment thread docs/env-vars.md Outdated
Comment thread frontend/README.md Outdated
- Update AWS example values to be more realistic
- Remove redundant "Required for Dev?" column
- Improve descriptions in frontend README
@p-retrover
Copy link
Copy Markdown
Contributor Author

Implemented suggested changes.

Comment thread docs/env-vars.md Outdated
Comment thread frontend/README.md Outdated
Comment thread docs/env-vars.md
@p-retrover
Copy link
Copy Markdown
Contributor Author

implemented the minor changes

@p-retrover
Copy link
Copy Markdown
Contributor Author

Hello 👋, just wanted to know can this be merged? If no, would love to get some feedback.
Thanks

Comment thread docs/env-vars.md Outdated
Comment thread docs/env-vars.md Outdated
Comment thread docs/env-vars.md Outdated
Comment thread docs/env-vars.md Outdated
Comment thread frontend/README.md Outdated
Comment thread docs/env-vars.md Outdated
Comment thread docs/env-vars.md Outdated
Comment thread docs/env-vars.md
@DarianM
Copy link
Copy Markdown
Member

DarianM commented Oct 16, 2025

Hello 👋, just wanted to know can this be merged? If no, would love to get some feedback.
Thanks

Hi @p-retrover thanks for your time and effort helping out with better docs! I'll approve and merge after a hew additions

p-retrover and others added 7 commits October 16, 2025 19:22
Co-authored-by: darianm <47156919+DarianM@users.noreply.github.com>
Co-authored-by: darianm <47156919+DarianM@users.noreply.github.com>
Co-authored-by: darianm <47156919+DarianM@users.noreply.github.com>
Co-authored-by: darianm <47156919+DarianM@users.noreply.github.com>
Co-authored-by: darianm <47156919+DarianM@users.noreply.github.com>
Co-authored-by: darianm <47156919+DarianM@users.noreply.github.com>
Co-authored-by: darianm <47156919+DarianM@users.noreply.github.com>
@p-retrover
Copy link
Copy Markdown
Contributor Author

implemented the reviewed changes, please confirm the changes.

@DarianM
Copy link
Copy Markdown
Member

DarianM commented Oct 16, 2025

implemented the reviewed changes, please confirm the changes.

🎉
can you please format the docs using pnpm format from root ?

@p-retrover
Copy link
Copy Markdown
Contributor Author

implemented the reviewed changes, please confirm the changes.

🎉 can you please format the docs using pnpm format from root ?

Done 👍

@DarianM DarianM merged commit 279f54e into interledger:main Oct 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants