fix(widget): viewport height responsiveness#434
Merged
Conversation
Deployment results
Logs #18839656084 |
sidvishnoi
reviewed
Oct 24, 2025
Collaborator
kjmitchelljr
left a comment
kjmitchelljr
left a comment
There was a problem hiding this comment.
I don't see any issues with the PR. As mentioned, could improve the image dimensions if there was ever a need to have it be more fluid with a layout change.
Only other question would be is how did you come to pick 140px as the number to subtract from?
Member
Author
It is based solely on the height of the trigger button + plus some distance between the top edge for the open content. |
sidvishnoi
reviewed
Oct 27, 2025
sidvishnoi
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #428
Changes
Remove the height media screen.
Instead, add scrollability to the entire container.
Adapt each view to have scrollability regardless of the viewport height.