Skip to content

fix(ToolsWalletAddress): Fix wrong text#450

Merged
sidvishnoi merged 1 commit intomainfrom
446-bug-wrong-text
Nov 27, 2025
Merged

fix(ToolsWalletAddress): Fix wrong text#450
sidvishnoi merged 1 commit intomainfrom
446-bug-wrong-text

Conversation

@kjmitchelljr
Copy link
Copy Markdown
Collaborator

Closes #446

  • Changed the ToolsWalletAddress component to accept a toolName prop
  • Updated the usage of ToolsWalletAddress in banner.tsx and widget.tsx to pass the correct toolName value

@kjmitchelljr kjmitchelljr linked an issue Nov 26, 2025 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

Deployment results

Worker Alias URL Outcome
API - staging success
CDN - staging success
App - 7babfeeb success

Logs #19715434929

Copy link
Copy Markdown
Member

@DarianM DarianM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to see locales in the near future to avoid developing this pattern whenever different text is needed in interactive tools

@sidvishnoi
Copy link
Copy Markdown
Member

it would be nice to see locales in the near future to avoid developing this pattern whenever different text is needed in interactive tools

I'd prefer entire text to be outside components - either passed as props, or from some locales files.

@sidvishnoi sidvishnoi merged commit 769d618 into main Nov 27, 2025
5 checks passed
@sidvishnoi sidvishnoi deleted the 446-bug-wrong-text branch November 27, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Wrong text

3 participants