Skip to content

fix(offerwall/builder): hide button close appearance details #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sidvishnoi merged 1 commit into from
Mar 3, 2026
Merged

fix(offerwall/builder): hide button close appearance details #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions frontend/app/components/offerwall/OfferwallBuilder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,6 @@ function AppearanceBuilder({ onRefresh }: Props) {
}
}}
onRefresh={onRefresh}
onDone={() => {
uiActions.setAppearanceComplete(true)
toolActions.setBuildCompleteStep('filled')
}}
initialIsOpen
>
<InputFieldset label="Text" icon={<SVGText className="w-5 h-5" />}>
Expand Down
28 changes: 14 additions & 14 deletions frontend/app/components/redesign/components/BuilderAccordion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { GhostButton } from './GhostButton'
interface BuilderAccordionProps {
title: string
onRefresh: () => void
onDone: () => void
onDone?: () => void
isComplete?: boolean
initialIsOpen?: boolean
onToggle?: (isOpen: boolean) => void
Expand All @@ -32,11 +32,6 @@ export const BuilderAccordion: React.FC<BuilderAccordionProps> = ({
onToggle?.(isOpen)
}

const handleDoneClick = () => {
setIsOpen(false)
onDone()
}

return (
<details
open={isOpen}
Expand Down Expand Up @@ -78,14 +73,19 @@ export const BuilderAccordion: React.FC<BuilderAccordionProps> = ({
{isOpen && (
<>
<Divider />
<div className="flex justify-end">
<ToolsSecondaryButton
className="w-full xl:w-[140px]"
onClick={handleDoneClick}
>
Done
</ToolsSecondaryButton>
</div>
{onDone && (
<div className="flex justify-end">
<ToolsSecondaryButton
className="w-full xl:w-[140px]"
onClick={() => {
setIsOpen(false)
onDone()
}}
>
Done
</ToolsSecondaryButton>
</div>
)}
</>
)}
</details>
Expand Down