Conversation
Deployment results
Logs #24389213856 |
sidvishnoi
reviewed
Apr 3, 2026
sidvishnoi
reviewed
Apr 3, 2026
sidvishnoi
reviewed
Apr 3, 2026
sidvishnoi
reviewed
Apr 3, 2026
kjmitchelljr
approved these changes
Apr 5, 2026
Collaborator
kjmitchelljr
left a comment
kjmitchelljr
left a comment
There was a problem hiding this comment.
Looks good, agree with the feedback Sid gave, but see those changes have already been added 👍🏿
Comment on lines
+35
to
+41
| {UMAMI_HOST && UMAMI_WEBSITE_ID && ( | ||
| <script | ||
| defer | ||
| src={`${UMAMI_HOST}/script.js`} | ||
| data-website-id={UMAMI_WEBSITE_ID} | ||
| /> | ||
| )} |
Collaborator
There was a problem hiding this comment.
nit: with this script injection here, do you think we should do any checks to make sure the URLs aren't malformed?
| const walletAddressInfo = await getWalletAddress(walletAddressUrl) | ||
| walletActions.setWalletAddressId(walletAddressInfo.id) | ||
| await connect() | ||
| trackEvent('wallet_connected') |
Collaborator
There was a problem hiding this comment.
nit: could be a later add, but thinking keeping the events in a separate file with a const map of event names as more events get added
sidvishnoi
reviewed
Apr 6, 2026
sidvishnoi
reviewed
Apr 6, 2026
Comment on lines
+20
to
+21
| "analytics:start": "pnpm --filter localenv-analytics start", | ||
| "analytics:stop": "pnpm --filter localenv-analytics stop" |
Member
There was a problem hiding this comment.
These can be replaced with pnpm -C localenv/analytics start command. If you believe that additional scripts like these are more ergonomic, feel free to keep them.
sidvishnoi
reviewed
Apr 6, 2026
sidvishnoi
approved these changes
Apr 6, 2026
sidvishnoi
reviewed
Apr 6, 2026
sidvishnoi
approved these changes
Apr 8, 2026
sidvishnoi
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #624
root.tsx, injected only whenUMAMI_HOSTandUMAMI_WEBSITE_IDare setlocalenv/umami/docker-compose.ymlEvent tracked as setup
wallet_connected/banner,/widget,/offerwallclick_card_toollinkNotes